Skip to content

Bump MSRV for rand 0.8 #1009

Closed
Closed
@vks

Description

@vks
Collaborator

TryFrom was stabilized with 1.34 and may allow us to get rid of some unsafe code. This is only a small bump from our current MSRV 1.32.

Are there any features that would justify a larger bump?

Activity

newpavlov

newpavlov commented on Aug 1, 2020

@newpavlov
Member

It would be nice to bump MSRV to 1.36 for a more straightforward alloc support.

dhardy

dhardy commented on Aug 1, 2020

@dhardy
Member

1.36 is over a year old. I don't believe there's a very good rationale for supporting anything older (even if I have been guilty of arguing against MSRV bumps too often).

vks

vks commented on Aug 1, 2020

@vks
CollaboratorAuthor

I agree, but this issue was more about possibly supporting a more recent version.

dhardy

dhardy commented on Aug 28, 2020

@dhardy
Member

Done in #1011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @vks@dhardy@newpavlov

        Issue actions

          Bump MSRV for rand 0.8 · Issue #1009 · rust-random/rand