rand-core: Cargo doc warning with version 0.4.0

[prataprc]

I am seeing these warnings while issuing as cargo doc command.

warning: `[impls::next_u32_via_fill]` cannot be resolved, ignoring it...                          
   --> /home/prataprc/.cargo/registry/src/github.com-1ecc6299db9ec823/rand_core-0.4.0/src/lib.rs:144:24
    |                                                                                             
144 |     /// [`fill_bytes`][impls::next_u32_via_fill].                                         
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^ cannot be resolved, ignoring                     
    |                                                                                     
    = note: #[warn(intra_doc_link_resolution_failure)] on by default                              
    = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]` 

warning: `[distributions::uniform::Uniform]` cannot be resolved, ignoring it...          
   --> /home/prataprc/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/lib.rs:241:22
    |                                                                                   
241 |     /// [`Uniform`]: distributions::uniform::Uniform                                             
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot be resolved, ignoring
    |                                                                                                  
    = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`

[dhardy]

Yes, we see them too, but testing shows the links work. Maybe you should tell the rustdoc team instead.

[QuietMisdreavus]

There's an open PR on rustdoc right now to fix some of the spurious warnings, but it's worth noting that some of the ones when documenting rand are not spurious - i've left a couple examples in rust-lang/rust#58745 (comment)

[dhardy]

Thanks for looking into this. As you found, the warnings are not all spurious. It turns out that running cargo doc for just rand_core does not generate any warnings, yet running it for the whole of rand does.

I guess then we should re-open this, though from our side I don't think there is anything we can do (other than dramatically simplifying cross-crate documentation, which is not currently well supported).

[dhardy]

Hmm, these warnings don't show up any more. #849 tracks broken links, which seems to be a manifestation of this.

Note that cargo doc does warn about rngs::SmallRng being unresolved; run with --all-features to fix this (as our CI does).