Closed
Description
Lines 141 to 147 in bf8b5a9
This function is wrong; to copy my comment from #958:
This is incorrect for 32-bit platforms. Check this out.
This isn't your fault;
to_u64
forf64
makes the same mistake. Hmm, even theTryFrom
in Rust 1.34 doesn't handle this conversion. I'm starting to hate this topic; seems simple but isn't.
Activity
dhardy commentedon Oct 19, 2020
The offending code was removed in #987 (including uses of it, so there is no replacement).