Skip to content

Conversation

Ablu
Copy link

@Ablu Ablu commented Jul 19, 2023

Summary of the PR

Some cleanup, then addition of virtio_ids.h

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@Ablu
Copy link
Author

Ablu commented Jul 20, 2023

turning into draft, blocked by: #249

@Ablu Ablu force-pushed the virtio-id-bindings branch from 2a70fe6 to 7480a31 Compare July 21, 2023 09:30
@Ablu Ablu marked this pull request as ready for review July 21, 2023 09:31
@Ablu Ablu requested a review from epilys as a code owner July 21, 2023 09:31
@Ablu
Copy link
Author

Ablu commented Jul 21, 2023

Unblocked, rebased on the already merged commit to bump to 6.4.

@Ablu Ablu force-pushed the virtio-id-bindings branch from 7480a31 to e1d9ece Compare July 21, 2023 09:36
@Ablu
Copy link
Author

Ablu commented Jul 21, 2023

CI had network issues, force-push to trigger rebuild

@@ -1,6 +1,7 @@
# Upcoming Release

- Regenerate bindings with Linux 6.4.
- Added bindings for virtio_ids.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing full stop

Erik Schilling added 3 commits August 29, 2023 19:12
We list the headers in the script snippet already. No need to do the
same here and force everyone to update two places.

Signed-off-by: Erik Schilling <[email protected]>
This prevents it from getting longer every time we extend this. Also,
it allows sorting the lines a bit easier.

Signed-off-by: Erik Schilling <[email protected]>
Generated from Linux v6.4.3.

Signed-off-by: Erik Schilling <[email protected]>
@epilys epilys force-pushed the virtio-id-bindings branch from e1d9ece to 09d367e Compare August 29, 2023 16:12
@epilys epilys merged commit 1f2dd43 into rust-vmm:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants