Skip to content

Conversation

paulrouget
Copy link
Contributor

This addresses 2 issues:

  1. OpenGL 3.0 was not selecting NSOpenGLProfileVersionLegacy
  2. because of a Rust bug, match behavior was selecting the wrong profile (this should be address by Rewrite the pattern matching code in trans. rust-lang/rust#27050)

@tomaka
Copy link
Contributor

tomaka commented Aug 10, 2015

While you're at it, I don't think requesting a core profile with a legacy version should return an error.

cc @fkaa @SSheldon

@paulrouget
Copy link
Contributor Author

What profile to use in his case? NSOpenGLProfileVersionLegacy?

@paulrouget paulrouget force-pushed the opengl-profile-selection-fix branch from 596307a to 26139f8 Compare August 11, 2015 02:42
@paulrouget
Copy link
Contributor Author

Switched to legacy for 1., 2., 3.0 and 3.1.

@tomaka
Copy link
Contributor

tomaka commented Aug 11, 2015

r+ for me. Leaving open for a day or two in case someone more familiar with OS/X has something to say.

tomaka added a commit that referenced this pull request Aug 13, 2015
@tomaka tomaka merged commit 5c60456 into rust-windowing:master Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants