Skip to content

Build refactor #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Build refactor #691

wants to merge 2 commits into from

Conversation

filmor
Copy link
Member

@filmor filmor commented Apr 13, 2025 •
edited
Loading

Refactor build logic to remove TOML dependency, implements #685.

@filmor filmor requested a review from Copilot April 27, 2025 11:14
Copilot

This comment was marked as resolved.

Sign in to view

@filmor filmor requested review from scrogson and evnu April 27, 2025 11:15
@scrogson
Copy link
Member

@filmor are there other benefits to this? Otherwise, it seems a bit heavy handed if we're just trying to remove a dependency.

@filmor
Copy link
Member Author

filmor commented May 1, 2025

  • It doesn't guess the artifact anymore but instead gets it from Rust's stable interface
  • It implements Rename libs as we copy them out of target #685, which ensures that the shared library is named the same on all platforms so the .beam file becomes platform-independent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@scrogson scrogson scrogson approved these changes

@evnu evnu Awaiting requested review from evnu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filmor @scrogson