Skip to content

server: use into for SignatureScheme. #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

server: use into for SignatureScheme. #325

merged 1 commit into from
Jul 10, 2023
+1 −21

Conversation

cpu
Copy link
Member

@cpu cpu commented Jul 7, 2023

This branch resolves a TODO in server.rs's sigschemes function, replacing a map'd match with into.

@cpu cpu self-assigned this Jul 7, 2023
cpu
cpu commented Jul 7, 2023
View reviewed changes
@cpu
Copy link
Member Author

cpu commented Jul 7, 2023

rustls-ffi / Clippy nightly (optional) (pull_request) Failing after 39s

As mentioned in this other comment I believe this is a FP.

@cpu
server: use into for SignatureScheme.
9a2dd4b 
This commit resolves a `TODO` in `server.rs`'s `sigschemes` function,
replacing a `map`'d `match` with `into`.
@cpu cpu force-pushed the cpu-tidy-into-todo branch from 69cd38e to 9a2dd4b Compare July 10, 2023 17:18
@cpu
Copy link
Member Author

cpu commented Jul 10, 2023

This feels trivial enough to merge with one +1 🚀

@cpu cpu merged commit d31e279 into rustls:main Jul 10, 2023
@cpu cpu deleted the cpu-tidy-into-todo branch July 10, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpu @ctz