Allow modern range of windows-sys versions #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't believe this puts any meaningful restrictions on improving the Windows verifier code in the future. The only thing that came to mind was better size assertions for |
djc
approved these changes
Feb 22, 2025
cpu
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off my past work (and all of its referenced prior art) in 1Password/arboard#176. The goal of this PR is to allow downstream users more flexibility in what version(s) of
windows-syscargo resolves into their lockfile.By allowing two versions in the range, users have a higher chance of being able to only build one version and we appease both the users who want to keep their dependencies stable while not holding back the wider ecosystem and users who want to be on the latest versions all the time.
These changes also include a new CI task to ensure that nothing added to
windows.rsruns into compatibility issues withwindows-sys0.59 (or any future versions we may add).