Skip to content

Added router crate #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2019
Merged

Added router crate #26

merged 6 commits into from
Mar 17, 2019

Conversation

David-OConnor
Copy link
Member

@David-OConnor David-OConnor commented Mar 16, 2019

Uses generics as endpoints: requires a function to update app state, and one to update a wasm_bindgen Closure.

@David-OConnor
Copy link
Member Author

Would apprec wisdom from anyone knows how to make the module doc check , or unwrap/expect_throw work.

@David-OConnor David-OConnor merged commit 9bd67ec into rustwasm:master Mar 17, 2019
@fitzgen
Copy link
Member

fitzgen commented Mar 18, 2019

Hey David -- I'd like us not to merge PRs to gloo without review by at least one other maintainer. Additionally, I'd like to get to a place where we have largely already done design/consensus work up front, and agree on at least a skeleton of an approach and niche in the design space that we are aiming for. I'm thinking we should have proposals like https://github.com/rustwasm/gloo/blob/master/.github/ISSUE_TEMPLATE/propose_design.md and consensus in that proposal thread before we get to sending PRs.

With that in mind, I'm going to revert this PR merge, but I'd love to see a proposal for this design in the router tracking issue, with some discussion about the potential alternatives, prior art, etc. And then who knows, maybe we will merge this exactly as-is again! Or maybe it will go through a little design iteration and get even better? But I'd like this to be a community project where we can all contribute to designs.

Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants