-
Notifications
You must be signed in to change notification settings - Fork 154
Add gloo-console-timer #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Happy to merge with nitpicks below addressed.
Yeah hard to test since the effects aren't visible to us. I think what you have written is fine.
Thanks @cbrevik!
Addressed feedback, but I see one of the doc tests doesn't build, so will have to fix that first. (The one using |
Maybe there is a better way to handle this than to I didn't want to add dependencies just to make that example compile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cbrevik!
Resolves #16
Adds the
gloo-console-timer
crate with theConsoleTimer
RAII type.Docs feature the preferred
scope
-method for measurement:Was a bit unsure how to write tests here, since it seems I cannot verify through tests that the measurement including label is printed to the console.