Error on invalid import attr position #4522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Judging by other PRs CI status, quite a few of these errors are coming simply from new Rust version and would happen on main branch too. I guess that needs to be fixed upstream first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference tests for imports used invalid syntax, and because we don't error on attributes in invalid position by default, it was silently passing anyway.
I've changed the import attributes to error by default (by the way, why do we not do this for all attributes? it seems like a pretty common footgun), fixed the test, changed it to
--target webso that we could actually see imported files in the JS snapshot, and updated snapshots.