-
Notifications
You must be signed in to change notification settings - Fork 16
Add Nn::TransitionLabelScorer #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimBe195
wants to merge
10
commits into
version-bump
Choose a base branch
from
tdp_label_scorer
base: version-bump
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larissakl
approved these changes
Jul 25, 2025
I'm OK with the current implementation, but if you want I have some suggestions on how to make it more compact:
Then when a new transition type is added we can just add another value to the string array and be done with it. Bonus points for adding a sentinel to the enum at the end and adding a compile time check to enforce this scorer having the right number of elements in the array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new label scorer
TransitionLabelScorer
which wraps a base LabelScorer and adds predefined transition scores to the base scores depending on the transition type of each request. The transition scores are all individually specified as config parameters.Depends on #147 for
std::to_array
.