Skip to content

Fix token exchange metadata tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/client/test_auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import httpx
import pytest
from pydantic import AnyHttpUrl
from pydantic import AnyHttpUrl, AnyUrl

from mcp.client.auth import (
ClientCredentialsProvider,
Expand Down Expand Up @@ -91,6 +91,7 @@ def oauth_metadata():
"authorization_code",
"refresh_token",
"client_credentials",
"token-exchange",
],
code_challenge_methods_supported=["S256"],
)
Expand Down Expand Up @@ -1014,6 +1015,7 @@ def test_build_metadata(
"authorization_code",
"refresh_token",
"client_credentials",
"token-exchange",
],
token_endpoint_auth_methods_supported=["client_secret_post"],
service_documentation=AnyHttpUrl(service_documentation_url),
Expand Down
8 changes: 3 additions & 5 deletions tests/server/fastmcp/auth/test_auth_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ async def test_metadata_endpoint(self, test_client: httpx.AsyncClient):
"authorization_code",
"refresh_token",
"client_credentials",
"token-exchange",
]
assert metadata["service_documentation"] == "https://docs.example.com/"

Expand Down Expand Up @@ -1030,7 +1031,7 @@ async def test_client_registration_invalid_grant_type(
assert error_data["error"] == "invalid_client_metadata"
assert error_data["error_description"] == (
"grant_types must be authorization_code and "
"refresh_token or client_credentials"
"refresh_token or client_credentials or token exchange"
)

@pytest.mark.anyio
Expand Down Expand Up @@ -1361,10 +1362,7 @@ async def test_metadata_includes_token_exchange(
response = await test_client.get("/.well-known/oauth-authorization-server")
assert response.status_code == 200
metadata = response.json()
assert (
"token-exchange"
in metadata["grant_types_supported"]
)
assert "token-exchange" in metadata["grant_types_supported"]

@pytest.mark.anyio
@pytest.mark.parametrize(
Expand Down