Skip to content

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Feb 16, 2024

Based on the loose tag 0.8.9

@mkoeppe
Copy link
Author

mkoeppe commented Feb 17, 2024

@videlec I don't know why the "link checker" is not feeling well, but apart from this, this is ready

@videlec
Copy link
Collaborator

videlec commented Feb 17, 2024

I am having a look.

@videlec
Copy link
Collaborator

videlec commented Feb 17, 2024

Apparently, the link checker correctly detects two redirections

URL        `https://pypi.python.org/pypi/pplpy/'
Name       `Python Package Index'
Parent URL http://localhost:8880/pplpy/, line 43, col 32
Real URL   https://pypi.org/project/pplpy/
Check time 3.129 seconds
Size       10.28KB
Warning    [http-redirected] Redirected to
           `https://pypi.org/pypi/pplpy/' status: 301 Redirect to
           Primary Domain.
           [http-redirected] Redirected to
           `https://pypi.org/project/pplpy/' status: 301 Moved
           Permanently.
Result     Valid: 200 OK

URL        `https://www.sphinx-doc.org/'
Name       `Sphinx'
Parent URL http://localhost:8880/pplpy/, line 5220, col 21
Real URL   https://www.sphinx-doc.org/en/master/
Check time 2.280 seconds
Warning    [http-redirected] Redirected to
           `https://www.sphinx-doc.org/en/master/' status: 302
           Found.
Result     Valid: 200 OK

@mkoeppe
Copy link
Author

mkoeppe commented Feb 17, 2024

I'd say that Download link is redundant, do you want me to just remove it?

@videlec
Copy link
Collaborator

videlec commented Feb 17, 2024

You mean the one in the readme?

@mkoeppe
Copy link
Author

mkoeppe commented Feb 17, 2024

I've fixed some links. Not sure where the remaining warning is coming from. Sphinx itself?

URL        `https://www.sphinx-doc.org/'
Name       `Sphinx'
Parent URL http://localhost:8880/pplpy/, line 5220, col 21
Real URL   https://www.sphinx-doc.org/en/master/
Check time 2.485 seconds
Warning    [http-redirected] Redirected to
           `https://www.sphinx-doc.org/en/master/' status: 302
           Found.

@videlec
Copy link
Collaborator

videlec commented Feb 17, 2024

I think that it comes from sphinx itself (I already saw that in another project). As a workaround there is a --ignore-url option to the link checker.

@videlec
Copy link
Collaborator

videlec commented Feb 17, 2024

Actually, this project was pplpy itself, see #29 :-)

@mkoeppe
Copy link
Author

mkoeppe commented Feb 17, 2024

I don't understand.

Is there something I should still fix here, or can it be merged?

@videlec
Copy link
Collaborator

videlec commented Feb 17, 2024

It is most likely that #29 conflicts with this PR. I will proceed with the merge and fix conflicts.

Thanks for the PR.

@mkoeppe
Copy link
Author

mkoeppe commented Feb 17, 2024

I've done the merged here for your convenience

@videlec
Copy link
Collaborator

videlec commented Feb 17, 2024

Wonderful. Thanks.

@videlec videlec merged commit 5710798 into sagemath:master Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.8.9 commit is not on the master branch
3 participants