Update ECL to 10.4.1 and Maxima to 5.22.1 - currently the latest releases.

[vbraun]

Note: See #10434 for a follow-up ticket.

Please update ECL and Maxima to the newest upstream release. Sage packages are here:

It's unsafe to build either ECL or Maxima in parallel, so we must not do this. Updated versions of ECL and Maxima can be found here:

http://boxen.math.washington.edu/home/kirkby/patches/ecl-10.4.1.spkg

http://www.stp.dias.ie/~vbraun/Sage/spkg/maxima-5.22.1.spkg

Note that you cannot upgrade one without the other; Both ECL and Maxima need to be upgraded simultaneously or build will fail.

Relevant tickets for ECL:

• Remove extra baggage from the ECL spkg #9493: Remove extra baggage from ECL 10.2.1.p1 (again). The package has been cleaned up, but I feel removing gmp sources is too dangerous.

• ECL in Sage will not build on Fedora 14, which will be released on 2nd November 2010 #10185: the old ecl-10.2.1 does not build on Fedora 14: Hopefully fixed with the updated ECL from this ticket.

Relevant tickets for maxima:

• maxima package fails to install ECL library #8645: ECL library "maxima.fasb" is built at new location. The patches from this bug have been incorporated into the maxima spkg, and maxima package fails to install ECL library #8645 can be closed after this ticket.

• update/upgrade maxima to latest upstream (5.21.1) #8731: update/upgrade Maxima to latest upstream (5.21.1): Latest upstream is nowadays 5.22.1.

• sum(1/(1+k^2), k, -oo, oo) returns 0 #8582: sum(1/(1+k^2), k, -oo, oo) returns 0: The new Maxima seems to be able to evaluate this correctly, at leasts it returns some expression with digamma functions.

The updated Maxima code seems to be more careful about signs which leads to doctest errors. Moreover, error reporting was changed. Therefore you need to apply the following patches to the Sage library (in this order):

• trac_10187_fix_easy_doctests.patch
• trac_10187_general_display_prefix_workaround.patch
• trac_10187_mark_some_doctests_random_until_9880_gets_merged.patch

Finally, you need to patch $SAGE_ROOT/local/bin/sage-maxima.lisp with

• trac_10187_sage-maxima_lisp.patch

Upstream: Workaround found; Bug reported upstream.

CC: @williamstein @jhpalmieri @qed777 @nexttime @jaapspies @jasongrout @kcrisman @kiwifb @jpflori

Component: packages: standard

Author: Volker Braun, David Kirkby

Reviewer: Karl-Dieter Crisman, David Kirkby, Volker Braun, Leif Leonhardy

Merged: sage-4.6.1.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/10187

[vbraun]

comment:2

The doctests show one maxima regression:

sage: t = log(sqrt(2) - 1) + log(sqrt(2) + 1); t
log(sqrt(2) - 1) + log(sqrt(2) + 1)
sage: u = t.maxima_methods(); u
MaximaWrapper(log(sqrt(2) - 1) + log(sqrt(2) + 1))
sage: u.logcontract()
log((sqrt(2) - 1)*(sqrt(2) + 1))

This simplified to 0 in a previous version. But at least its not wrong ;-)

The attached patch fixes all doctests except for a timeout in maxima. That one is a different issue with maxima, which forgets to print the general-display-prefix variable for errors:

(sage subshell) volker-desktop:sage vbraun$ ./local/bin/maxima -p ./local/bin/sage-maxima.lisp 
;;; Loading #P"/home/vbraun/Sage/sage/local/lib/ecl/sb-bsd-sockets.fas"
;;; Loading #P"/home/vbraun/Sage/sage/local/lib/ecl/sockets.fas"
;;; Loading #P"/home/vbraun/Sage/sage/local/lib/ecl/defsystem.fas"
;;; Loading #P"/home/vbraun/Sage/sage/local/lib/ecl/cmp.fas"
;;; Loading #P"/home/vbraun/Sage/sage/local/lib/ecl/sysfun.lsp"
Maxima 5.22.1 http://maxima.sourceforge.net
using Lisp ECL 10.4.1
Distributed under the GNU Public License. See the file COPYING.
Dedicated to the memory of William Schelter.
The function bug_report() provides bug reporting information.
(%i1) 1;
<sage-display>(%o1)                                  1
(%i2) 1==1;
incorrect syntax: = is not a prefix operator
1==
 ^
(%i2) 1=1;
<sage-display>(%o2)                                1 = 1

[sagetrac-drkirkby]

comment:3

FYI, here's the failures on OpenSolaris 06/2009 with those updated versions of Maxima and ECL.

sage -t  -long -force_lib devel/sage/sage/interfaces/maxima.py
*** *** Error: TIMED OUT! PROCESS KILLED! *** ***

	 [1800.2 s]
 
----------------------------------------------------------------------

The following tests failed:

	sage -t  -long -force_lib devel/sage/sage/symbolic/integration/integral.py # 6 doctests failed
	sage -t  -long -force_lib devel/sage/sage/symbolic/maxima_wrapper.py # 1 doctests failed
	sage -t  -long -force_lib devel/sage/sage/symbolic/expression.pyx # 11 doctests failed
	sage -t  -long -force_lib devel/sage/sage/misc/functional.py # 2 doctests failed
	sage -t  -long -force_lib devel/sage/sage/calculus/wester.py # 1 doctests failed
	sage -t  -long -force_lib devel/sage/sage/calculus/tests.py # 1 doctests failed
	sage -t  -long -force_lib devel/sage/sage/calculus/calculus.py # 5 doctests failed
	sage -t  -long -force_lib devel/sage/sage/calculus/functional.py # 1 doctests failed
	sage -t  -long -force_lib devel/sage/sage/plot/plot3d/transform.pyx # 1 doctests failed
	sage -t  -long -force_lib devel/sage/sage/interfaces/maxima.py # Time out
----------------------------------------------------------------------
Total time for all tests: 2628.2 seconds
make: *** [ptestlong] Error 192
drkirkby@hawk:~/sage-4.6.1.alpha0$ 

I've not applied any patches at this point. I'll apply patches and rerun later.

[kcrisman]

comment:4

Replying to @sagetrac-drkirkby:

FYI, here's the failures on OpenSolaris 06/2009 with those updated versions of Maxima and ECL.

sage -t  -long -force_lib devel/sage/sage/interfaces/maxima.py
*** *** Error: TIMED OUT! PROCESS KILLED! *** ***

	 [1800.2 s]
 

I'd be interested what happened if you manually removed the tests in that file which test the tab-completion for Maxima. I get a problem on Mac OS X Tiger with that file for exactly that reason. We haven't filed a ticket because nobody knows how to fix it, and tab-completion does work on that platform, just not the testing.

[vbraun]

comment:5

The TIMED OUT! error is the missing general-display-prefix, which causes the expect interface to wait forever for maxima to print its next prompt.

I've filed a bug upstream here: https://sourceforge.net/tracker/?func=detail&aid=3098375&group_id=4933&atid=104933

[kcrisman]

comment:6

Replying to @vbraun:

The TIMED OUT! error is the missing general-display-prefix, which causes the expect interface to wait forever for maxima to print its next prompt.

Okay, thanks - so that's unrelated to the Tiger timeout from earlier Maximas.

[vbraun]

comment:7

I've modified sage/interfaces/maxima.py to work with maxima's prompt_prefix instead. Patch is attached and fixes the remaining doctest error.

This requires that `$SAGE_LOCAL/bin/sage-maxima.lisp sets

; (setf *general-display-prefix* "<sage-display>")
(setf *prompt-prefix* "<sage-display>")

I've made a updated sage_scripts spkg here:
http://www.stp.dias.ie/~vbraun/Sage/spkg/sage_scripts-4.6.rc0.p0.spkg

To test this ticket, you need all three spkgs and both patches.

[vbraun]

Upstream: Workaround found; Bug reported upstream.

[sagetrac-drkirkby]

comment:10

One thing we don't don, which I think would be sensible, is to include the test suite for ECL. That adds 1.7 MB. From the README.ECL file:

	cd tests
	make

You will find two types of output files:

	*.out	The whole output of a test
	*.erg	The errors arising from a test

When there is no *.erg, it means that ECL passed the test.

Would it not be sensible to add these in? Then we could execute the tests with a spkg-check file, like we do other code which has self-tests.

Dave

[kcrisman]

comment:11

Replying to @vbraun:

I've modified sage/interfaces/maxima.py to work with maxima's prompt_prefix instead. Patch is attached and fixes the remaining doctest error.

Just a very minor note:

# we are now getting three lines of commented verbosity 

but of course you changed it to get rid of the extra two lines from our constantly added packages :) so it's now five lines. Might as well change that too so future people are confused.

[kcrisman]

comment:12

Also, be sure to include a test that shows #8729 is fixed, as that was closed as a duplicate on the condition that #8731's doctests would show that.