Merge pynac sources as src/sage/symbolic/ginac

[mkoeppe]

Pynac has a compile-time dependency on the Python library but is not installed using Python package infrastructure. This is problematic because Python users cannot install it using standard Python tools - for example for testing different Python versions.

Pynac has no other uses than as the core of the symbolic expressions facility of Sage; and cannot even be tested without Sage.

We merge Pynac (i.e., the directory https://github.com/pynac/pynac/tree/master/ginac) into the Sage library as src/sage/symbolic/ginac. It is not a very big package - one flat directory with 100 *.h and *.cpp files, a total of 50kLOC. (The existing !Python/Cython symbolics code in sage.symbolic, sage.calculus, sage.functions is about 60kLOC.)

The Pynac sources are compiled like other C++ sources that are already in the Sage source tree. They are linked into a single Python extension module, sage.symbolic.expression. All other extension modules that used to link to pynac (sage.libs.pynac.pynac, sage.symbolic.function, sage.symbolic.series etc.) are

• either refactored so that they only import helper functions provided by sage.symbolic.expression instead of having to cimport Pynac functions directly (see sage.symbolic.ring: Remove direct use of cimports from pynac #32391, sage.symbolic.function: Remove direct use of cimports from pynac #32407)
• or merged into the extension module sage.symbolic.expression (via Cython include statements, not by copy-paste of source code, to keep the diff small)

This solves the same issues that #30534 tried to address, which ran into unresolved technical difficulties.

It will also make it easier for Sage developers to make changes to Pynac and the related symbolic implementation.

Follow-up: #32387 Remove pynac spkg

Depends on #32391
Depends on #32407
Depends on #32461

CC: @kliem @kiwifb @antonio-rojas @DaveWitteMorris @slel @dimpase @tscrim @egourgoulhon @nbruin

Component: symbolics

Author: Matthias Koeppe, Jonathan Kliem

Branch: 0d0b58f

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32386

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,7 +2,7 @@
 
 Pynac has no other uses than as the core of the symbolic expressions facility of Sage; and cannot even be tested without Sage.
 
-We merge Pynac (i.e., the directory https://github.com/pynac/pynac/tree/master/ginac) into the Sage library as `src/sage/symbolics/ginac`. It is not a very big package - one flat directory with 100 *.h and *.cpp files, a total of 50kLOC.
+We merge Pynac (i.e., the directory https://github.com/pynac/pynac/tree/master/ginac) into the Sage library as `src/sage/symbolic/ginac`. It is not a very big package - one flat directory with 100 *.h and *.cpp files, a total of 50kLOC.
 
 This will solve the same issues that #30534 tried to address, which ran into unresolved technical difficulties.
 

[mkoeppe]

Branch: u/mkoeppe/merge_pynac_as_src_sage_symbolic_ginac

[mkoeppe]

comment:3

I ran git filter-branch -f --tree-filter 'rm -f Makefile.am; mkdir -p src/sage/symbolic/ginac; mv *.* src/sage/symbolic/ginac/; :' -- --all on pynac 0.7.29 and merged it here, thus preserving the relevant history

---

Last 10 new commits:

f3bb79f	Merge pull request #374 from slel/fix-exp-inv-hyp
a99791b	apply patches from #31479 and #31554
91cb6fa	apply trac 31869 fix pynac integer_content
d96393c	apply trac 30688 patch infinite loop in pynac
80269c5	apply trac 31645 handling of constant term in series
4caca2e	apply trac 31530 patch pynac power::subs
cba9038	trac 31585 32-bit overflow
8acb548	also fix /=
f2040c8	ginac/numeric.cpp: Only use builtin for smull_overflow if supported by the compiler
e43830d	Merge remote-tracking branch 'pynac-filtered/master' into t/32386/merge_pynac_as_src_sage_symbolic_ginac

[mkoeppe]

Commit: e43830d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2bbf412

build/pkgs/pynac: Remove

[sagetrac-git]

Changed commit from e43830d to 2bbf412

[mkoeppe]

comment:5

Next: Move stuff from sage.libs.pynac to sage.symbolic.ginac, leaving some deprecated reimports behind.

Help from Cython experts very welcome...

[sagetrac-git]

Changed commit from 2bbf412 to e693827

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e693827

Move stuff from sage.libs.pynac to sage.symbolic.ginac, leaving some deprecated reimports behind

[sagetrac-git]

Changed commit from e693827 to 0581bac

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0bfc24f	src/sage/symbolic/ginac/version.h.in: Remove
0581bac	src/sage/symbolic/ginac/pynac-config.h: New

[mkoeppe]

comment:8

This version compiles OK

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

496102d	src/sage/symbolic/ginac/utils.h, pynac-config.h: Eliminate use of PYNAC_SIZEOF_LONG, PYNAC_SIZEOF_LONG_LONG
fc29c1d	src/sage/symbolic/pynac.pyx, pynac.pxd: Fixup distutils: sources

[sagetrac-git]

Changed commit from 0581bac to fc29c1d