New ABC sage.structure.element.NumberFieldElement, deprecate is_NumberFieldElement

[mkoeppe]

We also make sage.rings.number_field a namespace package. This is necessary because .number_field_base is needed in sagemath-categories (#32432), whereas implementation modules depend on NTL.

Part of Meta-ticket #32414

CC: @tscrim

Component: refactoring

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34931

[mkoeppe]

Branch: u/mkoeppe/new_abc_sage_structure_element_numberfieldelement__deprecate_is_numberfieldelement

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a9dacbe

is_NumberFieldElement: Deprecate, replace uses by isinstance

[sagetrac-git]

Commit: a9dacbe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1cc09cc	Replace some imports of NumberFieldElement classes by ABC
4dfefbf	src/sage/rings/number_field/number_field_element.pyx: Update doctest with deprecation warning

[sagetrac-git]

Changed commit from a9dacbe to 4dfefbf

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

comment:5

Instead of adding the ABCDEFIT NumberFieldElement to sage.structure.element, we could also create a tiny new module sage.rings.number_field.number_field_element_base for it. Not sure which of the two is preferable.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bacff96

src/sage/rings/number_field/__init__.py: Remove

[sagetrac-git]

Changed commit from 4dfefbf to bacff96

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
+We also make `sage.rings.number_field` a namespace package.
+
 Part of Meta-ticket #32414

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-We also make `sage.rings.number_field` a namespace package.
+We also make `sage.rings.number_field` a namespace package. This is necessary because `.number_field_base` is needed in sagemath-categories (#32432), whereas implementation modules depend on NTL.
 
 Part of Meta-ticket #32414

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3e95ebf

src/sage/structure/element.pyx: Fix up doctest

[sagetrac-git]

Changed commit from bacff96 to 3e95ebf

[mkoeppe]

Removed branch from issue description; replaced by PR #35100