Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 27, 2023

📚 Description

Follow-up from #35322.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tornaria tornaria self-requested a review March 27, 2023 22:26
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 1, 2023

Work item: Add comments to the new all.py added in #35322 and here, explaining the purpose.

@tornaria tornaria mentioned this pull request Apr 4, 2023
4 tasks
@tornaria
Copy link
Contributor

tornaria commented Apr 4, 2023

I tested this as explained in #35322 (comment). No harmful interaction with system sagemath.

I also had a look at the patch and it LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 4, 2023

Thank you!

@tornaria tornaria mentioned this pull request Apr 4, 2023
5 tasks
@vbraun vbraun merged commit 78f152e into sagemath:develop Apr 6, 2023
@tobiasdiez tobiasdiez mentioned this pull request Nov 23, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants