CI Linux: Follow-up fix for conda-forge-python3.11 #36699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2023 16:55
…on3.... package is actually installed
…ad of ==, for fuzzy match
|
Documentation preview for this PR (built with commit df0ca5b; changes) is ready! 🎉 |
vbraun
force-pushed
the
develop
branch
2 times, most recently
from
883e05f to
e349b00
Compare
|
Thanks, Dima! |
|
I'm setting it to "blocker" so it can get merged in 10.2 |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 12, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The fix in sagemath#36534 was not complete. The job was named as intended conda- forge-python3.11, but it was still using 3.12, which failed in https://github.com/sagemath/sage/actions/runs/6827163299/job/18568706581 Fixed here, as tested with `tox -e docker-conda-forge- python3.11-standard -- config.status` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36699 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #36534 was not complete. The job was named as intended conda-forge-python3.11, but it was still using 3.12, which failed in https://github.com/sagemath/sage/actions/runs/6827163299/job/18568706581
Fixed here, as tested with
tox -e docker-conda-forge-python3.11-standard -- config.status📝 Checklist
⌛ Dependencies