Skip to content

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Oct 6, 2024

It is problematic to put a dummy package into the dependencies list. For instance, see #38774.

We move the check for the system R to spkg-configure.m4 of SPKG rpy2. Then we can replace R in the dependencies list with rpy2.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#38774 (merged here)

vbraun and others added 2 commits October 6, 2024 00:43
"make download-for-sdist" tries to download all standard sources
and fails if we depend on a dummy package. Presumably fine since the
r dummy package should only used at configure time.
@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 6, 2024

We can ignore the failure of "test-new" workflow. It failed because it forced installing r_jupyter, which depends on the syetem R, which is of course not existing.

@kwankyu kwankyu marked this pull request as ready for review October 6, 2024 14:26
@kwankyu kwankyu changed the title Check R in rpy2 Check the system R in SPKG rpy2 Oct 6, 2024
@kwankyu kwankyu added the p: CI Fix merged before running CI tests label Oct 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

Documentation preview for this PR (built with commit 12fd0db; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 6, 2024

Thanks!

@kwankyu kwankyu mentioned this pull request Oct 8, 2024
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 9, 2024
sagemathgh-38777: Check the system R in SPKG rpy2
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

It is problematic to put a dummy package into the dependencies list. For
instance, see sagemath#38774.

We move the check for the system R to `spkg-configure.m4` of SPKG rpy2.
Then we can replace R in the dependencies list with rpy2.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

sagemath#38774 (merged here)
    
URL: sagemath#38777
Reported by: Kwankyu Lee
Reviewer(s):
@vbraun vbraun merged commit f69dd69 into sagemath:develop Oct 12, 2024
14 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: blocker / 1 p: CI Fix merged before running CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants