Skip to content

moving the _pseudo_fraction_field method to categories #40748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2025
Merged

moving the _pseudo_fraction_field method to categories #40748

merged 2 commits into from
Sep 7, 2025

Conversation

fchapoton
Copy link
Contributor

after #39713, it is no longer needed to have this method in ring.pyx

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 9f77458; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 02dee9f into sagemath:develop Sep 7, 2025
27 of 34 checks passed
@fchapoton fchapoton deleted the moving_pseudo_frac branch September 7, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun