Allow initial value for uncontrolled components #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -204,7 +210,8 @@ exports[`Radio Button Group Disabled DOM Snapshot 1`] = ` | |||
| > | |||
| <input | |||
| aria-describedby={undefined} | |||
| checked={false} | |||
| checked={true} | |||
There was a problem hiding this comment.
I'm not sure why but this changed from false to true.
There was a problem hiding this comment.
@interactivellama the checkbox was being forced as controlled component even when checked was not given
There was a problem hiding this comment.
Yeah, it's like removing the !this.props.disabled caused this, but it seems appropriate to allow disabled options that are selected
|
The visual snapshots have been removed in this PR see |
|
@interactivellama how can i update the snapshots? |
3den
commented
Mar 26, 2018
| @@ -79,7 +83,8 @@ class Radio extends React.Component { | |||
| id={this.getId()} | |||
| name={this.props.name} | |||
| value={this.props.value} | |||
| checked={!this.props.disabled && this.props.checked} | |||
There was a problem hiding this comment.
@interactivellama if we kept this logic this component would always be controlled no mater what, disabled should not affect the checked state.
|
@interactivellama the png snapshots are back, i think this pr is ready for your final review. |
interactivellama
requested changes
Mar 28, 2018
components/forms/checkbox/index.jsx
Outdated
| @@ -68,6 +68,10 @@ const Checkbox = createReactClass({ | |||
| * The Checkbox is a controlled component, and will always be in this state. If checked is not defined, the state of the uncontrolled native `input` component will be used. | |||
| */ | |||
| checked: PropTypes.bool, | |||
| /** | |||
| * This is a uncontrolled component, and this will be the initial checked status. | |||
There was a problem hiding this comment.
Please update comment with:
/**
* This is the initial value of an uncontrolled form element and is present only to provide compatibility with hybrid framework applications that are not entirely React. It should only be used in an application without centralized state (Redux, Flux). "Controlled components" with centralized state is highly recommended. See [Code Overview](https://github.com/salesforce/design-system-react/blob/master/docs/codebase-overview.md#controlled-and-uncontrolled-components) for more information.
*/
| @@ -246,6 +246,10 @@ const Input = createReactClass({ | |||
| * The input is a controlled component, and will always display this value. | |||
| */ | |||
| value: PropTypes.string, | |||
| /** | |||
There was a problem hiding this comment.
Please update comment with:
/**
* This is the initial value of an uncontrolled form element and is present only to provide compatibility with hybrid framework applications that are not entirely React. It should only be used in an application without centralized state (Redux, Flux). "Controlled components" with centralized state is highly recommended. See [Code Overview](https://github.com/salesforce/design-system-react/blob/master/docs/codebase-overview.md#controlled-and-uncontrolled-components) for more information.
*/
| @@ -170,6 +170,10 @@ const propTypes = { | |||
| * The input is a controlled component, and will always display this value. | |||
| */ | |||
| value: PropTypes.string, | |||
| /** | |||
There was a problem hiding this comment.
Please update comment with:
/**
* This is the initial value of an uncontrolled form element and is present only to provide compatibility with hybrid framework applications that are not entirely React. It should only be used in an application without centralized state (Redux, Flux). "Controlled components" with centralized state is highly recommended. See [Code Overview](https://github.com/salesforce/design-system-react/blob/master/docs/codebase-overview.md#controlled-and-uncontrolled-components) for more information.
*/
| @@ -17,6 +17,10 @@ const propTypes = { | |||
| * This is a controlled component. This radio is checked according to this value. | |||
| */ | |||
| checked: PropTypes.bool, | |||
| /** | |||
There was a problem hiding this comment.
Please update comment with:
/**
* This is the initial value of an uncontrolled form element and is present only to provide compatibility with hybrid framework applications that are not entirely React. It should only be used in an application without centralized state (Redux, Flux). "Controlled components" with centralized state is highly recommended. See [Code Overview](https://github.com/salesforce/design-system-react/blob/master/docs/codebase-overview.md#controlled-and-uncontrolled-components) for more information.
*/
3den
commented
Mar 30, 2018
| * hybrid framework applications that are not entirely React. It should only be used in an application without | ||
| * centralized state (Redux, Flux). "Controlled components" with centralized state is highly recommended. | ||
| * See [Code Overview](https://github.com/salesforce/design-system-react/blob/master/docs/codebase-overview.md#controlled-and-uncontrolled-components) for more information. | ||
| */ |
interactivellama
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1305
Additional description
defaultValueon<Input>and<Textarea>.defaultCheckedon<Radio>and<Checkbox>.Pull Request Review checklist (do not remove)
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.