Skip to content

Slider: Use string in event callback #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

interactivellama
Copy link
Contributor

@interactivellama interactivellama commented Apr 12, 2018

Additional description

onChange and onInput now pass in event, { value: [string] }. This is a type change from @DanFerro great addition to the library. I've talked with him, and we agreed that it should be a string. This is not a breaking change, since the Slider was never released in a version.

Build docs is also run with updated prop comments.


Pull Request Review checklist (do not remove)

  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at snapshot strings.
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

onChange passes in `event, { value: [string] }`
@interactivellama interactivellama force-pushed the slider-event-parameters branch from bc483c1 to eb4e576 Compare April 12, 2018 22:06
@interactivellama interactivellama merged commit ce2610a into salesforce:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant