Fix parallel_map::execute_cancellation test #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidbarsky |
✅ Deploy Preview for salsa-rs canceled.
|
Veykril
force-pushed
the
veykril/push-pqxwpkxprotm
branch
from
a7fb825 to
87fdc13
Compare
CodSpeed Performance ReportMerging #637 will not alter performanceComparing Summary
|
davidbarsky
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #635, the test here is racy. After resolving the
wait_forit never actually executes cancellable work and so it might just finish computation without cancelling (the only place where it was able to cancel was when calling theinput.field(db)call. This brings the test more in line with howparallel_executedoes it.