feature: allow skipping the lifetime on #[salsa::interned] structs
#661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #661 will not alter performanceComparing Summary
|
Wilfred
reviewed
Jan 23, 2025
davidbarsky
force-pushed
the
davidbarsky/interned-structs-without-lifetimes-take-two
branch
from
231806c to
8ff97d7
Compare
Veykril
reviewed
Jan 26, 2025
Comment on lines
76
to
90
| impl salsa::plumbing::interned::Configuration for $StructWithStatic { | ||
| const DEBUG_NAME: &'static str = stringify!($Struct); | ||
| type Data<'a> = $StructDataIdent<'a>; | ||
| type Struct<'db> = $Struct< $($db_lt_arg)? >; | ||
| fn struct_from_id<'db>(id: salsa::Id) -> Self::Struct<'db> { | ||
| use salsa::plumbing::FromId; | ||
| $Struct(<$Id>::from_id(id), std::marker::PhantomData) | ||
| } | ||
| fn deref_struct(s: Self::Struct<'_>) -> salsa::Id { | ||
| use salsa::plumbing::AsId; | ||
| s.0.as_id() | ||
| } | ||
| } | ||
|
|
||
| type $StructDataIdent<$db_lt> = ($($field_ty,)*); |
There was a problem hiding this comment.
Any reason this got moved up out of the const _ scope?
There was a problem hiding this comment.
I thought it'd be necessary to get completions from rust-analyzer, but it wasn't. reverted.
davidbarsky
force-pushed
the
davidbarsky/interned-structs-without-lifetimes-take-two
branch
from
f7bb8c6 to
bd81aa4
Compare
nikomatsakis
approved these changes
Jan 27, 2025
davidbarsky
deleted the
davidbarsky/interned-structs-without-lifetimes-take-two
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for three features:
#[salsa::interned(no_lifetime)]allows skipping the'dblifetime.#[salsa::interned]structs now have public ingredients, which allows accessing the underlying, interned data through thesalsa::Idalone.In my view, the use of the above features should be discouraged, but they are necessary for rust-analyzer to migrate to the new version of Salsa.
This PR supersedes #632.