Skip to content

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Feb 21, 2025

Original guide doesn't reflect the switching to release-plz, and this PR updates it.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 9e7d106
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67b7dd5cb874c300086947b3

@MichaReiser
Copy link
Contributor

To me it seems that release-plz now immediately creates a PR with all changes since the last release and bumps the version number automatically. All that seems necessary is to merge that PR?

@g-plane
Copy link
Contributor Author

g-plane commented Feb 21, 2025

I think no. Should I remove this section in readme?

@MichaReiser
Copy link
Contributor

I'd find instruction useful on how to do a release because it's currently unclear to me what needs doing. I just noticed the automatically created release PR, that makes me wonder if manually bumping the version is still necessary

@g-plane
Copy link
Contributor Author

g-plane commented Feb 21, 2025

Maybe no need to do it manually, but I didn't try release-plz before.

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and we can iterate on the content as we gain more experience with release-plz

@Veykril Veykril disabled auto-merge March 19, 2025 14:19
@nikomatsakis nikomatsakis enabled auto-merge March 19, 2025 14:19
@Veykril Veykril disabled auto-merge March 19, 2025 14:19
@Veykril Veykril merged commit f1c233b into salsa-rs:master Mar 19, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 19, 2025
@g-plane g-plane deleted the release- branch March 19, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants