internal: use portable-atomic in IngredientCache to compile on powerpc-unknown-linux-gnu
#749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owerpc-unknown-linux-gnu`
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #749 will not alter performanceComparing Summary
|
Veykril
approved these changes
Mar 7, 2025
|
It looks like portable-atomic effectively treats this the item a lock on 32 bit platforms; we can always vendor. |
Merged
carljm
added a commit
to carljm/salsa
that referenced
this pull request
Mar 8, 2025
* master: internal: use `portable-atomic` in `IngredientCache` to compile on `powerpc-unknown-linux-gnu` (salsa-rs#749) perf: Store view downcaster in function ingredients directly (salsa-rs#720) perf: Some small perf things (salsa-rs#744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analyzer compiles on
powerpc-unknown-linux-gnu. Since #687, Salsa does not.However, since the Rust Project considers
powerpc-unknown-linux-gnuto be a Tier 2 platform with host tool support, we really should avoid breaking folks on that platform!For context, see this discussion on Zulip.