-
Notifications
You must be signed in to change notification settings - Fork 186
chore: Normalize imports style #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Effectively reformatted everything with ```toml imports_granularity = "Module" group_imports = "StdExternalCrate" reorder_imports = true ```
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #779 will not alter performanceComparing Summary
|
How do we plan on preserving this format style in the future or are we okay if the import style denormalizes over time? |
Great question, the main annoyance is that the rustfmt configs are still unstable 🙃 rust-analyzer will attempt to keep the ordering and style consistent (unsure if RustRover has a similar thing going on). I think it is fine if the style degrades over time, we can always do another one of these PRs every now and then, but right now imports are fairly chaotic. |
Also I picked |
For "I hate resolving conflicts" and "trivial |
Effectively reformatted everything with