Skip to content

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 26, 2025

Effectively reformatted everything with

imports_granularity = "Module"
group_imports = "StdExternalCrate"
reorder_imports = true

Veykril added 2 commits March 26, 2025 07:18
Effectively reformatted everything with
```toml
imports_granularity = "Module"
group_imports = "StdExternalCrate"
reorder_imports = true
```
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 4e00670
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67e39e83d426840008aaa21d

Copy link

codspeed-hq bot commented Mar 26, 2025

CodSpeed Performance Report

Merging #779 will not alter performance

Comparing Veykril:veykril/push-npsmszmlrsql (4e00670) with master (20a347e)

Summary

✅ 12 untouched benchmarks

@MichaReiser
Copy link
Contributor

How do we plan on preserving this format style in the future or are we okay if the import style denormalizes over time?

@Veykril
Copy link
Member Author

Veykril commented Mar 27, 2025

Great question, the main annoyance is that the rustfmt configs are still unstable 🙃 rust-analyzer will attempt to keep the ordering and style consistent (unsure if RustRover has a similar thing going on). I think it is fine if the style degrades over time, we can always do another one of these PRs every now and then, but right now imports are fairly chaotic.

@Veykril
Copy link
Member Author

Veykril commented Mar 27, 2025

Also I picked imports_granularity = "Module" given it reduces git conflicts between PRs to some extent. The option here is up to debate.

@davidbarsky
Copy link
Contributor

davidbarsky commented Mar 27, 2025

For "I hate resolving conflicts" and "trivial git blame" reasons, I'd personally vote for imports_granularity = "Item", but I know the format is extremely ugly controversial 😅

@Veykril Veykril added this pull request to the merge queue Mar 28, 2025
Merged via the queue into salsa-rs:master with commit a89e3d2 Mar 28, 2025
11 checks passed
@Veykril Veykril deleted the veykril/push-npsmszmlrsql branch March 28, 2025 05:22
@github-actions github-actions bot mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants