Lack of namespaces / PSR-4 compliance

[hackel]

Please make sure all of your classes have proper namespaces so that they may be safely used in a 3rd-party project. I would highly recommend adhering to the PSR-4 autoloading standard: http://www.php-fig.org/psr/psr-4/

[andig]

@salsify-dev would you accept a PR? I'm failing to use this lib for exactly the same reason.

[gonzofy]

@andig I would be happy to accept a PR.

[andig]

@gonzofy just found that there is already a working fork at https://github.com/Im0rtality/jsonstreamingparser/ You can create the PR from there yourself ;) I've also submitted further patch for large integers that is waiting for acceptance.

[gonzofy]

@andig Thanks for that. @darrenoh put up a PR as you can see, but it brings over a bunch of changes that I don't want to straight up accept.

[gonzofy]

@andig I don't see the PR for large integers; is that here or in the fork?

[andig]

Its unaccepted in the fork: Im0rtality#1. Should I reraise against yours?

[gonzofy]

Very happy to accept against mine. Thanks!

On Sat, Sep 19, 2015 at 2:42 PM, andig [email protected] wrote:

Its unaccepted in the fork: Im0rtality#1
Im0rtality#1. Should I
reraise against yours?

—
Reply to this email directly or view it on GitHub
#29 (comment)
.

[andig]

See here for the changes Im0rtality/jsonstreamingparser@master...andig:fix
Unfortunately cant push with giving you the rest of the fork, too.

[gonzofy]

Closed by PR #32

[andig]

@gonzofy it's not closed- the bigint issue has not been merged upstream!

See Im0rtality/jsonstreamingparser@master...andig:fix as I cannot push without re-forking.

[gonzofy]

@andig the issue with namespaces seems unrelated to the PR you linked to for BigInts unless I'm missing something. I've re-opened for now, but could you be more specific about what's wrong?

[andig]

@gonzofy namespaces are fixed, I'll open new issue for bigint, thank you!

[gonzofy]

Thanks @andig !!