Improve the package handling

[noelmcloughlin]

This PR evolves formula while avoiding regression - this PR builds on #194 and supersedes #186
UPDATE: Resolves #200
UPDATE 2: Resolves #205

defaults.yaml Improvements

• Populate pkgs list with common package names across all supported distros.
• Depreciate pip.pkgname (handled by osfamilymap.yaml instead).

init.sls Improvements

• Remove hard-coding of package names in pkg.installed.
• Add refresh to pkg.installed
• Remove docker-py requirements state (see docker-package-dependencies instead).
• Add docker-py.pip.installed: pip in case someone REALLY needs pypi pip (pillar triggered).

compose.sls Cleanup

• Remove superfluous compose.docker-compose-pip state (already handled by init.sls).
• Add require: pkg: docker.docker-package-dependencies so we depend on init.sls

osfamilymap.yaml Cleanup

• Remove common package names - they exist in default.yaml instead
• Depreciate pip.pkgname.

osmap.yaml Cleanup

• Depreciate pip.pkgname

pillar.example Cleanup

• Depreciate pip.pkgname - its still supported (in case its used) but must not be documented

[noelmcloughlin]

I'll investigate Travis CI jobs - might be related to #182 and other stuff.

[noelmcloughlin]

Added commit to use python3-pip on Suse (see #198)

[noelmcloughlin]

Travis is broken on this formula - failures are not PR related.

[noelmcloughlin]

Last commit is workaround for broken pip states on Python3 and/or Suse 15.0.

See: #198

  ID: docker-package
    Function: cmd.run
        Name: /usr/bin/pip install  pip
      Result: True
     Comment: onlyif condition is false
     Started: 09:08:45.842677
    Duration: 0.773 ms
     Changes:

[myii]

@noelmcloughlin Thanks for this. Just a quick eyeball review for now.

[mattwillsher]

FWIW this fixed the install issue I was having running the formula against Ubuntu Bionic:

2019-03-06 20:25:30,088 [salt.state       :3487][CRITICAL][22093] Rendering SLS 'base:docker' failed: while parsing a blo
ck mapping
  in "<unicode string>", line 25, column 7
did not find expected key
  in "<unicode string>", line 26, column 7

[noelmcloughlin]

Thanks @mattwillsher for testing the PR

@aboe76 @javierbertoli @myii Are you happy to merge? There is also a growing backlog of issues for this formula and travis is broken too. I have tested this PR many times without issue.

[noelmcloughlin]

BTW FWIW there is interesting gotcha regarding kernel and dockerd documented here.

If you execute yum\apt\zypper update via CLI the kernel may get upgraded (but you are not warned). The Dockerd daemon fails with obscure iptables errors until you reboot!!!

[noelmcloughlin]

Resolves #205 too.