Skip to content

Add support for configure pg_ident.conf #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2018
Merged

Add support for configure pg_ident.conf #181

merged 2 commits into from
Mar 12, 2018

Conversation

EvaSDK
Copy link
Contributor

@EvaSDK EvaSDK commented Jan 17, 2018

Basically a copy/paste of pg_hba.conf.

noelmcloughlin
noelmcloughlin approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks. Please update pillar.example in future PR if helpful.

vutny
vutny suggested changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@vutny vutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @EvaSDK .
But defining empty identity_map in the defaults is required for this to work for all the others.
Also giving some trivial example in the pillar.example file would be really great.

This should finally supersede long-awaiting PR #79.

@noelmcloughlin noelmcloughlin mentioned this pull request Feb 22, 2018
Closed
@EvaSDK EvaSDK force-pushed the handle-pg_ident-conf branch from 9e07e14 to f048ab8 Compare March 12, 2018 15:49
@EvaSDK
Copy link
Contributor Author

EvaSDK commented Mar 12, 2018

Finally got some time to update this PR, hopefully everything is covered now. I also fixed a few typos that made it through the first time.

@aboe76 aboe76 merged commit 9b6f86a into saltstack-formulas:master Mar 12, 2018
@aboe76
Copy link
Contributor

aboe76 commented Mar 12, 2018

@EvaSDK thanks for this

@EvaSDK
Copy link
Contributor Author

EvaSDK commented Mar 13, 2018

Thanks for taking the time to review PRs and merge them :)

@EvaSDK EvaSDK deleted the handle-pg_ident-conf branch March 13, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vutny vutny vutny requested changes

@noelmcloughlin noelmcloughlin noelmcloughlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EvaSDK @aboe76 @noelmcloughlin @vutny