Don't set modes with every run

[SuperTux88]

• postgresql-cluster-prepared: dir_mode is set in postgresql-config-dir
• postgresql-config-dir: file_mode for some files is set to 600, and I think all other files are good with default mode. So don't touch any files, only change dirs.

Otherwise these states are changed back and fort every run:

----------
          ID: postgresql-cluster-prepared
    Function: file.directory
        Name: /var/lib/postgresql/10/main
      Result: True
     Comment: Directory /var/lib/postgresql/10/main updated
     Started: 00:46:33.002033
    Duration: 539.572 ms
     Changes:   
              ----------
              mode:
                  0755
----------
          ID: postgresql-config-dir
    Function: file.directory
        Name: /var/lib/postgresql/10/main
      Result: True
     Comment: Directory /var/lib/postgresql/10/main updated
     Started: 00:46:33.565329
    Duration: 235.267 ms
     Changes:   
              ----------
              mode:
                  0644
----------
          ID: postgresql-config-dir
    Function: file.directory
        Name: /etc/postgresql/10/main
      Result: True
     Comment: Directory /etc/postgresql/10/main updated
     Started: 00:46:33.801441
    Duration: 2.057 ms
     Changes:   
              ----------
              mode:
                  0644
----------
          ID: postgresql-pg_hba
    Function: file.managed
        Name: /etc/postgresql/10/main/pg_hba.conf
      Result: True
     Comment: File /etc/postgresql/10/main/pg_hba.conf updated
     Started: 00:46:33.808804
    Duration: 746.758 ms
     Changes:   
              ----------
              mode:
                  0600
----------
          ID: postgresql-pg_ident
    Function: file.managed
        Name: /etc/postgresql/10/main/pg_ident.conf
      Result: True
     Comment: 
     Started: 00:46:34.556873
    Duration: 1.279 ms
     Changes:   
              ----------
              mode:
                  0600
----------
          ID: postgresql-running
    Function: service.running
        Name: postgresql
      Result: True
     Comment: Service reloaded
     Started: 00:46:34.583204
    Duration: 51.512 ms
     Changes:   
              ----------
              postgresql:
                  True

[noelmcloughlin]

Thanks for PR. I notice updates from #202 change got lost, could you fix that also please.

[SuperTux88]

What exactly got lost? {{ postgres.conf_dir }} is still set to dir_mode: {{ postgres.conf_dir_mode }}, which is 0700 in the defaults.yaml, so postgres shouldn't have a problem to start.

[noelmcloughlin]

You're absolutely right - I incorrectly thought file_mode was included in #202 also.

[noelmcloughlin]

LGTM, thanks!

[aboe76]

@SuperTux88 thanks for the fix, @noelmcloughlin thanks for reviewing