-
Notifications
You must be signed in to change notification settings - Fork 283
fix(sysrc-svc): workaround *BSD minion indefinitely hanging on start #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vutny If you don't have any FreeBSD hosts to test this PR: I've got them and I use this formula. :-) |
@alxwr Is this the correct way to do this ? I've seen you changed the way to do this on https://github.com/saltstack-formulas/prometheus-formula but don't know if it is applicable here |
@sticky-note I still use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sticky-note Just tested this PR on FreeBSD 11.2. Works as expected. Thanks for this!
Please just make the service watch the sysrc flags.
Otherwise: LGTM
095b022
to
61910a7
Compare
@alxwr Updated |
@sticky-note We've got -fix(sysrc-svc): Workaround *BSD minion undefinitely hanging on start
+fix(sysrc-svc): workaround *BSD minion indefinitely hanging on start Update: Just a little typo fix in the commit message as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me, since there are no regressions. Thanks @sticky-note .
Just need to fix that minor issue with commit message for all tests to pass.
Check saltstack/salt#44848 for further details
@alxwr @vutny Thanks for the reviews. |
🎉 This PR is included in version 0.37.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Check saltstack/salt#44848 for further details