Skip to content

fix(sysrc-svc): workaround *BSD minion indefinitely hanging on start #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2019

Conversation

sticky-note
Copy link
Member

Check saltstack/salt#44848 for further details

@myii myii requested a review from vutny April 29, 2019 22:30
@alxwr
Copy link
Member

alxwr commented Apr 30, 2019

@vutny If you don't have any FreeBSD hosts to test this PR: I've got them and I use this formula. :-)
@sticky-note Thanks for this!

@sticky-note
Copy link
Member Author

@alxwr Is this the correct way to do this ? I've seen you changed the way to do this on https://github.com/saltstack-formulas/prometheus-formula but don't know if it is applicable here

@alxwr
Copy link
Member

alxwr commented May 2, 2019

@sticky-note I still use >/dev/null 2>&1. Just refactored my code a bit.

@alxwr alxwr self-requested a review May 3, 2019 23:16
Copy link
Member

@alxwr alxwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sticky-note Just tested this PR on FreeBSD 11.2. Works as expected. Thanks for this!
Please just make the service watch the sysrc flags.

Otherwise: LGTM

alxwr added a commit to alxwr/postgres-formula that referenced this pull request May 3, 2019
@sticky-note sticky-note force-pushed the master branch 2 times, most recently from 095b022 to 61910a7 Compare May 7, 2019 00:30
@sticky-note sticky-note changed the title Workaround for FreeBSD minion undefinitely hanging on service start fix(sysrc-svc): Workaround *BSD minion undefinitely hanging on start May 7, 2019
@sticky-note
Copy link
Member Author

@alxwr Updated

@myii
Copy link
Contributor

myii commented May 7, 2019

@sticky-note We've got semantic-release active on this repo (it looks like you already know this). The commit message is just failing the commitlint because of the capital letter. If you can amend the commit and then force push it back again, it will ensure you get a release once this PR is merged:

-fix(sysrc-svc): Workaround *BSD minion undefinitely hanging on start
+fix(sysrc-svc): workaround *BSD minion indefinitely hanging on start

Update: Just a little typo fix in the commit message as well.

Copy link
Contributor

@vutny vutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, since there are no regressions. Thanks @sticky-note .
Just need to fix that minor issue with commit message for all tests to pass.

@sticky-note sticky-note changed the title fix(sysrc-svc): Workaround *BSD minion undefinitely hanging on start fix(sysrc-svc): workaround *BSD minion undefinitely hanging on start May 12, 2019
@sticky-note sticky-note changed the title fix(sysrc-svc): workaround *BSD minion undefinitely hanging on start fix(sysrc-svc): workaround *BSD minion indefinitely hanging on start May 12, 2019
@myii myii merged commit 65519cb into saltstack-formulas:master May 12, 2019
@myii
Copy link
Contributor

myii commented May 12, 2019

@alxwr @vutny Thanks for the reviews.
@sticky-note Thanks for the contribution -- merged.

@saltstack-formulas-travis

🎉 This PR is included in version 0.37.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants