Skip to content

ci: enable Vagrant-based testing using GitHub Actions #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

myii
Copy link
Contributor

@myii myii commented Mar 26, 2021

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The existing FreeBSD pre-salted image we had here hasn't been working for a while (deprecated version 12.0). This PR updates that; furthermore, actually performs the Vagrant testing in GitHub Actions.

Did attempt to also introduce OpenBSD and Windows testing but the formula has too many failures for that currently.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii myii requested review from vutny and a team as code owners March 26, 2021 12:21
@myii myii force-pushed the ci/add-vagrant-testing-via-github-actions branch from 676064f to ed2d688 Compare March 26, 2021 14:59
@myii myii merged commit 0ee210c into saltstack-formulas:master Mar 26, 2021
@myii
Copy link
Contributor Author

myii commented Mar 26, 2021

Self-merge, CI and docs only.

@myii myii deleted the ci/add-vagrant-testing-via-github-actions branch March 26, 2021 16:37
@saltstack-formulas-travis

🎉 This PR is included in version 0.41.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants