Re-define default exporter port 9922 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow NFS-Ganesha and use the default Prometheus port-allocations for Samba-exporter (9922) as defined by: https://github.com/prometheus/prometheus/wiki/Default-port-allocations Signed-off-by: Shachar Sharon <[email protected]>
Allow running exporter with explicit port-number. If input port-number is non positive, use default port-number. Signed-off-by: Shachar Sharon <[email protected]>
Allow user to control the Prometheus metrics port number. If non is given, use default port-number. Signed-off-by: Shachar Sharon <[email protected]>
Align exposed port-number with default Prometheus-exporter port. Signed-off-by: Shachar Sharon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default Samba-exporter port value from (same as NFS-Ganesha):
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
Allow override via command-line flag.