stabilize ESP8266 watchdog #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepmistry
requested changes
Nov 21, 2017
src/LoRa.cpp
Outdated
| @@ -144,7 +144,11 @@ int LoRaClass::endPacket() | |||
| writeRegister(REG_OP_MODE, MODE_LONG_RANGE_MODE | MODE_TX); | |||
|
|
|||
| // wait for TX done | |||
| while((readRegister(REG_IRQ_FLAGS) & IRQ_TX_DONE_MASK) == 0); | |||
| while((readRegister(REG_IRQ_FLAGS) & IRQ_TX_DONE_MASK) == 0) | |||
| #ifdef ESP8266 | |||
There was a problem hiding this comment.
I think we should remove the #ifdef and call yield on all architectures.
There was a problem hiding this comment.
I wasn't sure if this is working on all platform, thats why I set the guard. If you think so, I prefere!
|
request applied! |
|
@universam1 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve the watchdog timeout issue on ESP8266
fixes #38