Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our indexing always makes my head hurt because of the variety of paths through the logic but I think we are getting simpler/more robust. Adding this as a single commit so @DeepBlockDeepak can cherry-pick if desired to test if this unblocks the tensor tutorial work. Otherwise we can merge and iterate. See commit for the couple of changes I made. I updated our tests to cover the failure modes you described but let me know if you think I need to add something additional.
Interface Note: MATLAB uses a lot of column vectors to resolve ambiguities but those are generally less common in python since numpy defaults to a more generic
(length,)
array. My preference is to take a list or effective row vector for linear indices and force people trying to use subscripts to always to provide a matrixnp.array([[0,1,2]])
even if the nesting isn't generically necessary.For the exact motivation, here is the behavior off the branch which I believe aligns mostly with expectations.