Skip to content

Properly handle pkg: imports with args #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Properly handle pkg: imports with args #2193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
776937b
Properly handle `pkg:` imports with args
nex3 Mar 12, 2024
449ce0c
Merge branch 'main' into pkg-args
nex3 Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* When printing suggestions for variables, use underscores in variable names
when the original usage used underscores.

### JavaScript API

* Properly resolve `pkg:` imports with the Node.js package importer when
arguments are passed to the JavaScript process.

## 1.71.1

### Command-Line Interface
Expand Down
2 changes: 1 addition & 1 deletion lib/src/js/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ Syntax parseSyntax(String? syntax) => switch (syntax) {
String? get entrypointFilename {
if (_requireMain?.filename case var filename?) {
return filename;
} else if (process.argv case [_, String path]) {
} else if (process.argv case [_, String path, ...]) {
return module.createRequire(path).resolve(path);
} else {
return null;
Expand Down