Preserve line endings that libsass hands us #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -749,7 +744,7 @@ def test_sassc_output(self): | |||
| assert exit_code == 0 | |||
| assert self.err.getvalue() == '' | |||
| assert self.out.getvalue() == '' | |||
| with open(tmp) as f: | |||
| with io.open(tmp, encoding='UTF-8', newline='') as f: | |||
There was a problem hiding this comment.
this acts as a regression test
|
@dahlia thoughts on this? It changes behaviour but makes our wrapper both more transparent and more like the other implementations. |
| b(A_EXPECTED_CSS_WITH_MAP), | ||
| r.data | ||
| r.data, |
There was a problem hiding this comment.
Trailing commas are a best practice :D
|
Looks good to me! |
|
<3 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160