Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Add sass-spec tests #429

Merged
merged 2 commits into from
Sep 23, 2014
Merged

Add sass-spec tests #429

merged 2 commits into from
Sep 23, 2014

Conversation

ndhoule
Copy link
Contributor

@ndhoule ndhoule commented Sep 22, 2014

Adds the sass-spec test suite. Continued from #222.

I mostly ported over those changes, with the exception of a few fixes:

  • Now uses the same CSS formatter used in sass-spec. (Not sure if that's related to the Windows line handling issue noted in [WIP] Sass spec testing #222.)
  • Test suite fails if sass-spec isn't cloned into place, or if any sass-spec tests are failing. Seemed like if sass-spec should replace any non-middleware functionality, then test passage should be dependent on sass-spec tests passing.

Interestingly, the test suite was failing at first, but I rebuilt the binary per the readme/#428 and all tests (including the one noted in #427) passed.

Related issues: #161, #424, #427, #428

@ndhoule ndhoule changed the title Add node-sass tests Add sass-spec tests Sep 22, 2014
@am11
Copy link
Contributor

am11 commented Sep 23, 2014

@andrew, LGTM! 👍
AppVeyor test is failing due to some kind of timeout. It is not triggering node scripts/test intermittently for some crazy reason (perhaps their thread / dyno gets sleepy..) /cc @deepak1556

@andrew
Copy link
Contributor

andrew commented Sep 23, 2014

Yeah this is pretty awesome, the binary situation is pretty crappy right now, hopefully we can get it to a better place soon.

andrew added a commit that referenced this pull request Sep 23, 2014
@andrew andrew merged commit 2e10b28 into sass:master Sep 23, 2014
@ndhoule ndhoule mentioned this pull request Sep 23, 2014
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants