Skip to content

[Snyk] Security upgrade react-scripts from 1.1.5 to 4.0.0 #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade react-scripts from 1.1.5 to 4.0.0 #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/concurrent/time-slicing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"react": "0.0.0-experimental-269dd6ec5",
"react-dom": "0.0.0-experimental-269dd6ec5",
"react-markdown": "^3.2.0",
"react-scripts": "^1.1.4",
"react-scripts": "^4.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This major version upgrade of react-scripts from v1 to v4 introduces significant breaking changes and is highly likely to break this fixture.

  • Peer Dependency Conflict: [email protected] has a peer dependency on react@>=16.8.0. The experimental version 0.0.0-experimental-269dd6ec5 used in this fixture does not satisfy this requirement, which will likely cause dependency installation to fail.
  • Breaking API/Tooling Changes: The jump from v1 to v4 involves major upgrades to underlying tools like Babel and Webpack. The fixture's code, which relies on experimental React features, may not be compatible with the new build configuration without a significant migration effort.

Given this is an automated security upgrade, a less disruptive fix should be considered, such as using Yarn's resolutions to update the specific vulnerable transitive dependency. If react-scripts must be upgraded, it will require a manual migration of this fixture.

"victory": "^0.25.6"
},
"scripts": {
Expand Down
Loading