Skip to content

[Snyk] Security upgrade webpack from 1.15.0 to 2.2.0 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade webpack from 1.15.0 to 2.2.0 #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/packaging/webpack/dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": true,
"name": "webpack-dev-fixture",
"dependencies": {
"webpack": "^1.14.0"
"webpack": "^2.2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading webpack from v1 to v2 is a major version bump that introduces breaking changes. This will likely break the build for this fixture.

The associated webpack configuration file, fixtures/packaging/webpack/dev/config.js, uses the resolve.root option, which was removed in webpack v2. The build script in this package.json will fail when webpack is executed with this configuration.

To resolve this, the config.js file needs to be updated for webpack v2. Specifically, resolve.root should be replaced with resolve.modules.

For example:
Webpack v1 (config.js)

resolve: {
  root: path.resolve('../../../../build/node_modules/'),
}

Webpack v2 (required change in config.js)

resolve: {
  modules: [
    path.resolve('../../../../build/node_modules/'),
    'node_modules', // Also recommended to add 'node_modules'
  ],
}

This PR should be updated to include the necessary configuration changes to ensure the fixture remains buildable.

},
"scripts": {
"build": "rm -f output.js && webpack --config config.js"
Expand Down
Loading