Call getCanonicalPath instead of getAbsolutePath #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to relativize when basePath is provided as a relative path
|
LGTM |
|
Hi. In scoverage plugin we have problem with calculating source files paths relative to source root directories they are inside for reporting purposes (see this and this). Our issue is not resolved yet. It's in common code used by SBT, Maven and Gradle plugins, so it's important to have working solution for all contexts. SBT 0.13.x didn't canonize paths and I personally was against canonizing paths in our code because of:
My question is, will SBT 1.0 canonize:
I don't know where the changed methods are used. Can I test it somehow? |
This was referenced Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to relativize when basePath is provided as a relative path.
This is useful when we have to work with "schims" for supporting functionality across different Scala/ScalaJS versions that pull in sources from paths relative to the base directory, like in sourcecde. Some SBT plugins rely on this function to tell whether or not a file is in a directory or not.