Skip to content

Set javafmtOnCompile := false by default #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Conversation

armanbilge
Copy link
Contributor

It seems like this was already decided in #70 (comment) but was deferred to enable a smooth transition.

@ennru
Copy link
Contributor

ennru commented Nov 8, 2021

I agree, it is time to finally do this switch. Please update even the instructions in the Readme.

@ennru ennru added this to the 0.7.0 milestone Nov 8, 2021
@armanbilge
Copy link
Contributor Author

In aa2f583 I made an on-compile-true and on-compile-false test from the old on-compile.

Copy link
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 1fc9fcc into sbt:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants