Skip to content

Adding additional test case to Std Lib Maps #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2016

Conversation

bcchapman
Copy link

@bcchapman bcchapman commented Jun 28, 2016

This case demonstrates the behavior of attempting to call myMap(missingKey) in that an exception is thrown. It also provides examples of how to handle this gracefully using default values via either getOrElse or for the entire map with withDefaultValue. Also included corresponding test case.

@raulraja
Copy link
Member

LGTM! Thanks for your contribution!

@raulraja raulraja merged commit 7d17e8e into scala-exercises:master Jun 29, 2016
@ghost
Copy link

ghost commented Jun 29, 2016

Hi @bcchapman and thanks a lot for contributing. We've noticed that your git email is not the same you have on GitHub, hence your commits are not linked to your GitHub user. Note how in this PR the GitHub logo is shown in the commits instead of your avatar.

This is not a big problem but we can't include these commits in the list of contributions shown in the website, we don't have a way to link the contributions to your GitHub user. Again, thanks for your time!

@bcchapman
Copy link
Author

Hi @dialelo Thanks for catching this. This was due to a different email being the default in my git client. In the future I will be sure to make sure those align.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants