Skip to content

Make ArrayBuilder reusable on 2.11 #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjrd opened this issue Jan 9, 2017 · 1 comment
Closed

Make ArrayBuilder reusable on 2.11 #2717

sjrd opened this issue Jan 9, 2017 · 1 comment
Assignees
@sjrd
Labels
upstream This issue derives from a bug or a change in one of our upstream dependencies.
Milestone
v0.6.16

Comments

@sjrd
Copy link
Member

sjrd commented Jan 9, 2017

It is already reusable in 2.12 since 4f3115f

It's been made reusable in 2.11 upstream as a backport in scala/scala#5615, so now we need to backport that change too.
@sjrd sjrd added the upstream This issue derives from a bug or a change in one of our upstream dependencies. label Jan 9, 2017
@sjrd sjrd added this to the v0.6.15 milestone Jan 9, 2017
@sjrd sjrd modified the milestones: v0.6.16, v0.6.15 Mar 18, 2017
@sjrd sjrd self-assigned this Apr 25, 2017
@sjrd sjrd mentioned this issue Apr 25, 2017
Closed
47 tasks
sjrd added a commit to sjrd/scala-js that referenced this issue Apr 26, 2017
@sjrd
Fix scala-js#2717: Make ArrayBuilder reusable in 2.11.
6d441f6 
This is a backport of
scala/scala@23040fe
to our override of `ArrayBuilder` for 2.11, combined with the
changes of 4f3115f to
`ArrayBuilder.generic`.
@sjrd sjrd added the has-pr label Apr 26, 2017
sjrd added a commit that referenced this issue Apr 26, 2017
@sjrd
Merge pull request #2912 from sjrd/reusable-arraybuilder-scala-2.11
8c74fa1 
Fix #2717: Make ArrayBuilder reusable in 2.11.
@sjrd
Copy link
Member Author

sjrd commented Apr 26, 2017

Fixed in #2912.

@sjrd sjrd closed this as completed Apr 26, 2017
@sjrd sjrd removed the has-pr label Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjrd sjrd

Labels
upstream This issue derives from a bug or a change in one of our upstream dependencies.
Projects
None yet
Milestone
v0.6.16
Development

No branches or pull requests
1 participant
@sjrd