Consider module accessor a JSGetter #2541
Conversation
|
Can one of the admins verify this patch? |
| @@ -108,13 +108,13 @@ trait JSGlobalAddons extends JSDefinitions | |||
|
|
|||
| /** has this symbol to be translated into a JS getter (both directions)? */ | |||
| def isJSGetter(sym: Symbol): Boolean = { | |||
| sym.tpe.params.isEmpty && enteringUncurryIfAtPhaseAfter { | |||
| sym.isModule || (sym.tpe.params.isEmpty && enteringUncurryIfAtPhaseAfter { | |||
There was a problem hiding this comment.
we only get here when sym.isMethod, thus sym.isModule can only hold for the module's accessor
There was a problem hiding this comment.
Could you write that as a comment in the code?
See https://github.com/scala-js/scala-js/blob/master/CODINGSTYLE.md#non-scaladoc-comments for the style we use for comments.
|
Jenkins, test this please |
|
That's all. Thanks! |
Redundant on 2.11, but required for the upcoming 2.12.0-RC1, where the field refactoring synthesizes module accessors after uncurry, so that their type history does not even go back as far as uncurry, where a NullaryMethodType might have been observed otherwise. I tried splicing NMTs in the info history of modules, but they already are pretty hacking (a module's term symbol is converted into a method pretty late in the game, and it would be risky to have them start with NMTs from namers).
adriaanm
force-pushed
the
2.12-fields-compat
branch
from
80d9829 to
21e499c
Compare
|
Amended my commit. |
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3311/ |
|
LGTM Jenkins, retest this please |
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3316/ |
Redundant on 2.11, but required for the upcoming 2.12.0-RC1,
where the field refactoring synthesizes module accessors
after uncurry, so that their type history does not even
go back as far as uncurry, where a NullaryMethodType might
have been observed otherwise.
I tried splicing NMTs in the info history of modules,
but they already are pretty hacking (a module's term symbol
is converted into a method pretty late in the game, and it
would be risky to have them start with NMTs from namers).
With this, scala-js's test suite passes on scala/scala#5141
(well, I'm about to rewind that branch to a stable point where this holds)
TODO