Use releaseNotesUrl even if repoUrl is empty #2890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #2863. Before this change, the `info.releaseNotesUrl` property from the POM was ignored if `project.scm.url` and `project.url` were not set. With this change the `releaseNotesUrl` is added to the PR even if the other two are not set.
Codecov ReportBase: 88.96% // Head: 88.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2890 +/- ##
==========================================
- Coverage 88.96% 88.95% -0.01%
==========================================
Files 157 157
Lines 3026 3024 -2
Branches 202 211 +9
==========================================
- Hits 2692 2690 -2
Misses 334 334
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mzuehlke
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2863. Before this change, the
info.releaseNotesUrlproperty from the POM was ignored ifproject.scm.urlandproject.urlwere not set (sinceDependencyMetadata#repoUrlis then empty too). With this change thereleaseNotesUrlis added to the PR even if the other two are not set.