This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Fixes for #114 #136
Merged
Fixes for #114 #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BuildFrom` is like `FromSpecificIterable` but with an extra `From` argument, like in the final version of #45. `FromSpecificIterable` existed conceptually in that version as `BuildFrom[Any, …]` but didn’t have a separate type. This new version has separate abstractions for buildable (strict) collection types in the form of `StrictBuildFrom` and `FromSpecificIterableWithBuilder`. Since we can get a surrogate builder (through one of the new `Builder.from` methods) for any lazy collection and we can restrict code to work only with strict collections via the `Buildable` trait, this is not strictly necessary. The only reason for separating the `Builder` abstractions is to avoid exposing them in `FromSpecificIterable`. Even though everything can be built in a strict way, these abstractions sit on top of the lazy ones, not below them.
Consistently order the collection type constructor (`CC`) and collection (`C`) type in `SortedOps`
Remove default implementations of newBuilder method.
julienrf
force-pushed
the
new-strict-building-fixes
branch
from
1d0fecb to
bfbfc0e
Compare
|
I rebased #114 on master and squashed all the commits into a single one. Then I fixed the compilation errors. |
|
So did I because that's what we discussed in this week's meeting. Except that my rebase effort wasn't quite finished yet because #110 split up the factories into strict and lazy ones despite our preference for having strict building everywhere in the previous meeting. We need to be more efficient with how we spent our time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@szeiger is that OK for you to merge this?