Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Fix the iterableFactory of mutable Sets #470

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Conversation

szeiger
Copy link
Contributor

@szeiger szeiger commented Feb 20, 2018

This points to a soundness bug in the compiler. These errors should be
caught. Omitting a necessary override leads to the expected errors in
some cases but not in all.

This points to a soundness bug in the compiler. These errors should be
caught. Omitting a necessary override leads to the expected errors in
some cases but not in all.
@julienrf
Copy link
Contributor

Omitting a necessary override leads to the expected errors in
some cases but not in all.

I hope we can fix that in the compiler :(

@szeiger
Copy link
Contributor Author

szeiger commented Feb 20, 2018

Looks like a similar issue to scala/bug#7093, present in Scala and Dotty, with no solution since it was opened 5 years ago, so I wouldn't hold my breath.

@szeiger szeiger merged commit 01d3f3a into master Feb 20, 2018
@szeiger szeiger deleted the wip/fix-set-factories branch February 20, 2018 16:43
@szeiger
Copy link
Contributor Author

szeiger commented Feb 21, 2018

I could have held my breath after all because Dotty fixed it: scala/scala3#4013. See my comment there. Not only are we exploiting unsound protected[this] in my design changes, we already did before, just as the old collections library does.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants